Bug 757 - Motif changes to linux.cf break build for most linux users
Summary: Motif changes to linux.cf break build for most linux users
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Monolithic (show other bugs)
Version: git
Hardware: x86 (IA32) FreeBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-16 03:32 UTC by Eric Anholt
Modified: 2011-10-15 15:46 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
remove new HasMotif (and friends) defines (1.90 KB, patch)
2004-06-16 03:33 UTC, Eric Anholt
no flags Details | Splinter Review

Description Eric Anholt 2004-06-16 03:32:55 UTC
The XPRINT merge added lines to linux.cf, FreeBSD.cf, and NetBSD.cf to define
HasMotif YES.  However, this is not the case on most of our users' machines, and
has created a decent bit of support load on irc with people getting errors about
Xm includes.  Seems like we ought to apply the following and let people set
HasMotif if they actually have it. (untested)
Comment 1 Eric Anholt 2004-06-16 03:33:54 UTC
Created attachment 374 [details] [review]
remove new HasMotif (and friends) defines
Comment 2 Roland Mainz 2004-06-16 07:32:54 UTC
Eric Anholt wrote:
> The XPRINT merge added lines to linux.cf, FreeBSD.cf, and NetBSD.cf to define
> HasMotif YES. 

Known issue. I described that in
http://freedesktop.org/pipermail/release-wranglers/2004-April/000589.html but
until today (e.g. two months) I didn't saw any complaints or bugzilla bugs...

> However, this is not the case on most of our users' machines, 
> and has created a decent bit of support load on irc with people getting errors 
> about Xm includes.  Seems like we ought to apply the following and let people 
> set HasMotif if they actually have it. (untested)

The problem is that there are libraries in the tree which depend on the Motif
libraries. Usually they do not get build because the Linux distributions don't
turn |HasMotif| "on" and then the libraries do not get build.
The usual "solution" is to ship those libs with the applications then... but
that has caused serious problems in the past. Yes... I know... Linux people
don't care about binary compatibility - but the problem has reached a point
where the term "DLL h*ll" is an understatement... ;-(

Same applies to some tools in the tree... I am still unhappy about the detail
that xstshowfont will never be part of the tree because it does not make sense
to have a major tool in the tree which don't get build on platforms where it is
needed.

BTW: Why did you remove the |HasGhostScript| setting, too ? AFAIK even FreeBSD
has GhostScript installed by default - and unlike Motif GhostScript is not a
shared library so you won't get linker issues.
Comment 3 Eric Anholt 2004-06-16 12:32:21 UTC
No, FreeBSD definitely doesn't have Ghostscript or Motif by default.  An
argument could be made that ghostscript will be installed on most FreeBSDers'
machines that are installing xorg (I would disagree, but they should use ports
anyway, where dependencies like that would be handled automatically), but
HasMotif defaulting to YES is definitely not an option.

Few people have Motif installed, and I think that "At least almost everybody has
it installed" should be a requirement for Has* to be set by default.  I have a
hard time convincing myself that the default HasExpat for FreeBSD is even
justified, and just about everyone has that.  The HasMotif thing seems to be
especially and issue because as far as I know you're going to need your xorg
installed to be able to build motif...
Comment 4 Roland Mainz 2004-07-01 15:29:26 UTC
Mhhh, I'll meet Egbert next week and then we'll debate the issue and make a
decision whether the tree should depend on Motif or not.
Comment 5 Eric Anholt 2004-07-04 16:00:12 UTC
Committed a fix.  GhostScript was left in because it doesn't appear to be a
build dependency, it will probably be wanted by anyone using Xprint, and Xprint
is its only consumer.  Leaving that in still feels dirty.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.