Bug 828 - hppa linux build broken
Summary: hppa linux build broken
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency treegraph
 
Reported: 2004-07-06 03:00 UTC by Donnie Berkholz
Modified: 2004-08-08 22:40 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
6.7.0-hppa-fixes.patch (1.03 KB, patch)
2004-07-06 03:01 UTC, Donnie Berkholz
no flags Details | Splinter Review

Description Donnie Berkholz 2004-07-06 03:00:55 UTC
One of our hppa guys gave this patch to me and told me it was necessary to fix
hppa compiles. Let me know if there's a problem with it, and I'll bug him.
Comment 1 Donnie Berkholz 2004-07-06 03:01:23 UTC
Created attachment 443 [details] [review]
6.7.0-hppa-fixes.patch
Comment 2 Donnie Berkholz 2004-07-06 03:14:59 UTC
Credit to Guy Martin <gmsoft@gentoo.org>.
Comment 3 Paul Anderson 2004-08-05 21:26:19 UTC
Please adjust the test from

#ifdef __hppa__ 

to

#if defined(hpux) || defined __hppa__


Otherwise, this change may break builds on HP-UX.
If other patches have gone in that simply substitute
__hppa__ for hpux, we'll need to look at those as well.

This brings up another side issue.  It appears that
"HPArchitecture" in the config files has been overloaded.
Historically, it was used for HP-UX builds, but it looks
like it is now being used to denote builds on HP-PA
architectures (see Imake.cf, linux.cf).  Sometime in
the future, we should reexamine this and see if we need
to make any changes so that both builds can co-exist 
in the same tree. 
Comment 4 Donnie Berkholz 2004-08-07 18:55:02 UTC
Guy, can you please add an updated patch reflecting the above comments? I don't
have any access to Linux at the moment.
Comment 5 Kevin E. Martin 2004-08-09 15:40:29 UTC
I've made these changes and checked them in.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.