Bug 1119 - Build breaks with UseInstalled* and ProjectRoot set
Summary: Build breaks with UseInstalled* and ProjectRoot set
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Monolithic (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Egbert Eich
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency tree / graph
 
Reported: 2004-08-18 02:44 UTC by Alexander Gottwald
Modified: 2011-10-15 15:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
proposed patch (3.29 KB, patch)
2004-08-21 03:53 UTC, Alexander Gottwald 		no flags Details | Splinter Review
View All

Description Alexander Gottwald 2004-08-18 02:44:58 UTC 
If UseInstalledOnCrossCompile YES is set then the installed programs are
searched in $(BINDIR) which is ProjectRoot/bin. If ProjectRoot is set to
something different then /usr/X11R6 the programs are not found.

Proposed solution: 
introduce and use INSTALLED_BINDIR = InstalledProjectRoot/bin 
InstalledProjectRoot will default to ProjectRoot but can be customized in host.def
Comment 1 Kevin E. Martin 2004-08-18 16:19:08 UTC 
We talked about this on today's release wranglers call and agree that it could
go in, but would like to see a patch.  Most of it is very straightforward, with
the exception of changing the appropriate BINDIRs to INSTALLED_BINDIRs.  It
would be best if you could create a patch, verify that it works for you, and
then attach it to this bug report.

Then, those who also use UseInstalled* will be able to test out the patch before
it is applied.
Comment 2 Alexander Gottwald 2004-08-20 05:04:23 UTC 
UseInstalledX11 and UseInstalled will require more drastic changes. 

I will provide at least a patch for UseInstalledOnCrossCompile this weekend
Comment 3 Alexander Gottwald 2004-08-21 03:53:50 UTC 
Created attachment 700 [details] [review]
proposed patch

This patch only covers the UseInstalledOnCrossCompile situation.
It uses the already present X11ProjectRoot and the macro XBINDIR instead of
BINDIR.

The patch for UseInstalled will require a lot of changes since it must set many
includedirs and more problematic, the configdir. 

Another problem is version.def. the buildprocess tries to create it in the
ProjectRoot which will alter installed files during the build process which
will   most likely fail if you're not root on the machine.

So UseInstalled is broken regardless how you set the ProjectRoot
Comment 4 Egbert Eich 2004-08-25 08:57:39 UTC 
Assign to myself.
Comment 5 Egbert Eich 2004-08-27 06:22:34 UTC 
I'm not sure what X11ProjectRoot was originally intended for.
It has been in the XFree86 repository since day one (when this repository was
created). And as usually there is no comment describing it :-((

However the fix seems to be sane. I will commit it. Anyway, I don't expect that
this variable is used much.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.