Bug 1169 - Add count checking to DMA on Radeon.
Summary: Add count checking to DMA on Radeon.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) All
: high normal
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-23 19:58 UTC by Eric Anholt
Modified: 2004-09-16 05:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
radeon-dma-sanity.diff (2.36 KB, patch)
2004-08-23 20:00 UTC, Eric Anholt 		no flags Details | Splinter Review
View All

Description Eric Anholt 2004-08-23 19:58:09 UTC 
We've seen a couple of bugs now involving mistakes in the
BEGIN_RING/ADVANCE_RING counts or mistakes of missing them entirely.  I'd like
to add code to check that what happens inside of BEGIN/ADVANCE pairs matches
expectations.  Attached is a patch which has verified a couple of bugs.  I don't
expect the extra conditionals are expensive enough to warrant conditionalizing
them at compile time.
Comment 1 Eric Anholt 2004-08-23 20:00:55 UTC 
Created attachment 713 [details] [review]
radeon-dma-sanity.diff
Comment 2 Eric Anholt 2004-09-16 22:17:01 UTC 
Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.