Bug 1360 - xcompmgr doesn't check XQueryTree's return value
Summary: xcompmgr doesn't check XQueryTree's return value
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xcompmgr (show other bugs)
Version: unspecified
Hardware: All All
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-13 16:52 UTC by Johan Kiviniemi
Modified: 2011-10-15 17:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Check XQueryTree's return value (514 bytes, patch)
2004-09-13 16:53 UTC, Johan Kiviniemi 		no flags Details | Splinter Review
View All

Description Johan Kiviniemi 2004-09-13 16:52:16 UTC 
xcompmgr (from CVS) doesn't check XQueryTree's return value. This causes it to 
segfault when starting konqueror: certain XQueryTree calls seem to fail and the 
for loop in determine_wintype() is called with an uninitialized nchildren. 
 
The attached patch seems to fix it for me. 
 
PS. There seems to be also another unchecked XQueryTree call in xcompmgr.c at 
line 1884. This patch does not affect it.
Comment 1 Johan Kiviniemi 2004-09-13 16:53:38 UTC 
Created attachment 893 [details] [review]
Check XQueryTree's return value
Comment 2 Adam Jackson 2004-09-14 12:04:05 UTC 
applied, thanks.  this should be in 1.1 once i tag it.
Comment 3 Adam Jackson 2004-09-14 12:04:38 UTC 
.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.