a lot of code in Xext uses K&R style declarations
Created attachment 951 [details] [review] fix k&r declarations all of the patches as one because there is no size limit
the patch contents look good to me, but this doesn't apply against Xorg head. is this patch generated from the xlibs Xext?
(In reply to comment #2) > the patch contents look good to me, but this doesn't apply against Xorg head. > is this patch generated from the xlibs Xext? Yeah it is actually against xlibs Xext. Turns out Xorg head has the NeedFunctionPrototypes stuff already ripped out along with some whitespace cleanups. I'll redo the patch against Xorg head and then make a new patch against xlibs Xext that updates it to match Xorgg head. Sound ok?
Created attachment 952 [details] [review] new patch against xorg head here is the new patch against xorg head. I was thinking about syncing xlibs-xext with xorg-xext and thought maybe one bulk patch is not the best way to do things. Is it worth doing incrementals to match xorg-xext? Is there any sort of policy as to which way and how updates should flow between them?
i am told that the monolithic xlibs are authoritative, and that updates flow from monolithic to modular until such time as we abandon the monolithic tree. this one looks good, builds fine here. i'll commit this if no one beats me to it.
checked in, thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.