Bug 1758 - pclcomp doesn't compile
Summary: pclcomp doesn't compile
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: All Linux (All)
: high major
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-01 10:30 UTC by Bernhard Rosenkraenzer
Modified: 2004-11-01 21:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix (274 bytes, patch)
2004-11-01 10:33 UTC, Bernhard Rosenkraenzer 		no flags Details | Splinter Review
Patch for 2004-10-02-trunk (140.53 KB, patch)
2004-11-02 16:40 UTC, Roland Mainz 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Bernhard Rosenkraenzer 2004-11-01 10:30:28 UTC 
pclcomp.c:339: warning: function declaration isn't a prototype 
pclcomp.c:339: error: conflicting types for 'malloc' 
pclcomp.c:339: error: conflicting types for 'malloc' 
 
A simple fix is to just remove the broken conflicting declaration; attaching a 
patch
Comment 1 Bernhard Rosenkraenzer 2004-11-01 10:33:55 UTC 
Created attachment 1205 [details] [review]
Fix
Comment 2 Adam Jackson 2004-11-02 10:09:11 UTC 
roland, this is your bug, you added pclcomp in the first place.
Comment 3 Roland Mainz 2004-11-02 15:06:27 UTC 
ajax@nwnk.net wrote:
> roland, this is your bug, you added pclcomp in the first place

Weired, I've tested on SuSE Linux 8.2/x86 and Solaris/SPARC and didn't hit a
fatal compiler error (but it produces lots of warnings).

My fault - taking bug myself...
Comment 4 Roland Mainz 2004-11-02 16:40:59 UTC 
Created attachment 1211 [details] [review]
Patch for 2004-10-02-trunk

The patch should kill most of the warnings and all the errors...
Comment 5 Roland Mainz 2004-11-02 16:45:25 UTC 
Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.501; previous revision: 1.500
/cvs/xorg/xc/programs/pclcomp/pclcomp.c,v  <--  pclcomp.c
new revision: 1.2; previous revision: 1.1
Mailing the commit message to xorg-commit@pdx.freedesktop.org...


... marking bug as FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.