Bug 1795 - CVS xpr does not compile
Summary: CVS xpr does not compile
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: All All
: high normal
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 1779
Blocks:
  Show dependency tree / graph
 
Reported: 2004-11-08 04:22 UTC by Bernhard Rosenkraenzer
Modified: 2004-11-07 18:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix (3.54 KB, patch)
2004-11-08 04:22 UTC, Bernhard Rosenkraenzer 		no flags Details | Splinter Review
Diff for commit (2004-11-08-trunk) (12.11 KB, patch)
2004-11-08 13:36 UTC, Roland Mainz 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Bernhard Rosenkraenzer 2004-11-08 04:22:14 UTC 
Current CVS does a couple of bad things, like declaring an array defined in 
xpr.c extern in xpr.c, and writing to read-only locations. 
 
gcc 3.4.x refuses to compile this.
Comment 1 Bernhard Rosenkraenzer 2004-11-08 04:22:51 UTC 
Created attachment 1241 [details] [review]
Fix
Comment 2 Roland Mainz 2004-11-08 13:25:08 UTC 
Bernhard:
Thanks for the patch (actually it was my fault that I broke the tree with bug
1779) ...

... I'll take the bug for committing the patch.
Comment 3 Roland Mainz 2004-11-08 13:36:55 UTC 
Created attachment 1243 [details] [review]
Diff for commit (2004-11-08-trunk)
Comment 4 Roland Mainz 2004-11-08 13:40:16 UTC 
Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.511; previous revision: 1.510
/cvs/xorg/xc/programs/xpr/x2jet.c,v  <--  x2jet.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/xpr/xpr.c,v  <--  xpr.c
new revision: 1.3; previous revision: 1.2
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.