pbuf is not initialized in _XFopenFile. Later the pointer is checked for NULL and freed otherwise. If the file was not found the pointer is uninitialized and random memory is freed.
Created attachment 1310 [details] [review] [FIXED_X11R68x] initializes pbuf to NULL
/cvs/xorg/xc/lib/X11/XlibInt.c,v <-- XlibInt.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.528; previous revision: 1.527 fixed in HEAD
Comment on attachment 1310 [details] [review] [FIXED_X11R68x] initializes pbuf to NULL Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again.
Created attachment 1434 [details] [review] [FIXED_X11R68x] patch for XopenFile Fixing same error in _XopenFile /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.554; previous revision: 1.553 /cvs/xorg/xc/lib/X11/XlibInt.c,v <-- XlibInt.c new revision: 1.5; previous revision: 1.4
Comment on attachment 1434 [details] [review] [FIXED_X11R68x] patch for XopenFile Approved in the 2004-12-06 release-wranglers conference call. Please do not commit it yourself, I'll do that later today...
Comment on attachment 1310 [details] [review] [FIXED_X11R68x] initializes pbuf to NULL Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.26; previous revision: 1.365.2.25 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/lib/X11/XlibInt.c,v <-- XlibInt.c new revision: 1.2.4.1; previous revision: 1.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment on attachment 1434 [details] [review] [FIXED_X11R68x] patch for XopenFile Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.27; previous revision: 1.365.2.26 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/lib/X11/XlibInt.c,v <-- XlibInt.c new revision: 1.2.4.2; previous revision: 1.2.4.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org..
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.