Bug 638 - [810] DVO support
Summary: [810] DVO support
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: 6.7.0
Hardware: x86 (IA32) Linux (All)
: lowest minor
Assignee: Adam Jackson
QA Contact:
URL: http://www.maersk-moller.net/projects...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-18 00:34 UTC by Carl Karsten
Modified: 2008-06-25 13:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Carl Karsten 2004-05-18 00:34:21 UTC
Carl Karsten writes:
 > http://www.maersk-moller.net/projects/familynet/Xfree86.html says: "YUV 
overlay
 > does not work for the i810 Xfree86 driver (version 4.2.0 and below) when you
 > output to TV. " and some hacks to fix.
 > 
 > The xorg version is fairly different (or at least reorganized) but doesn't 
seem
 > to implement the fix.
 > 
 > Is there some reason not to add the DVO support?
 > 

No, there is none.
Please add an entry to bugzilla.freedesktop.org 
pointing to the page above.
This way we can track things much better.

Cheers,
Egbert.
Comment 1 Adam Jackson 2004-06-08 15:00:28 UTC
we seem to have equivalent code already.  from i810_driver.c:

   /* Setting the OVRACT Register for video overlay */
   {
       CARD32 LCD_TV_Control = INREG(LCD_TV_C);
       CARD32 TV_HTotal = INREG(LCD_TV_HTOTAL);
       CARD32 ActiveStart, ActiveEnd;

       if((LCD_TV_Control & LCD_TV_ENABLE)
          && !(LCD_TV_Control & LCD_TV_VGAMOD)
           && TV_HTotal) {
           ActiveStart = ((TV_HTotal >> 16) & 0xfff) - 31;
           ActiveEnd = (TV_HTotal & 0x3ff) - 31;
       } else {
           ActiveStart = i810Reg->OverlayActiveStart;
           ActiveEnd = i810Reg->OverlayActiveEnd;
       }
       OUTREG(LCD_TV_OVRACT,
              (ActiveEnd << 16) | ActiveStart);
   }

which looks like a generalized version of what's described in the URL.

has anyone actually tested this?
Comment 2 Adam Jackson 2004-07-26 12:39:47 UTC
accepting this one so i remember to find someone with an i810 to test.  but i
strongly suspect this is already fixed.
Comment 3 Adam Jackson 2004-07-26 12:40:18 UTC
bugzilla, you're stupid.
Comment 4 Adam Jackson 2004-08-10 09:23:21 UTC
from xfree86's i810_driver.c, revision 1.93 (in 4.3.99.14):

495. i830/i810 driver:
      * Added Christian Ziez's code to tweak BIOS image to convince chipset of
        resized video RAM.
      * Fixed viewport/video overlay window alingment issues.
      * Fixed calculation of video overlay memory size.
      * Fixed video overlay on TV out (BugzillaR #213). (Egbert Eich).
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is the source of the code in comment #1.  This look invalid, but I'll mark
it REMIND since I can't find anyone to test.
Comment 5 Carl Karsten 2004-08-10 12:02:16 UTC
I have an i810 box that I can test on.  What should I do to test and then
determine pass/fail?
Comment 6 Adam Jackson 2004-08-10 12:13:27 UTC
run xine or mplayer on the TV output and make sure it works as expected.
Comment 7 Carl Karsten 2004-08-10 12:24:38 UTC
I am not sure what to expect.  (Sorry to be such a dumb user)

I am not even sure if I should be looking for somethign visualy better, or less
CPU, or just "displays on TV"

Comment 8 Carl Karsten 2004-08-10 12:25:27 UTC
doh - clicked the "close" button - dam am I am luser <hangs head in shame>
Comment 9 Adam Jackson 2004-08-10 13:23:51 UTC
just "displays on TV" should be all.  the patch in question enables Xv to work
even on the TV output.
Comment 10 Adam Jackson 2004-09-16 20:17:44 UTC
carlk, ping.  have you tested this?
Comment 11 Adam Jackson 2005-02-01 19:27:39 UTC
reporter, ping again.
Comment 12 Adam Jackson 2005-03-26 19:04:35 UTC
closing this one as REMIND.  the code in CVS appears to match the desired
functionality.

if on testing this is found not to work, please reopen and explain.
Comment 13 Adam Jackson 2008-02-24 18:23:46 UTC
Mass reopen.  The "REMIND" resolution is lame, I'm deleting it.  Consider yourself reminded.
Comment 14 Gordon Jin 2008-02-25 19:19:03 UTC
Maybe we can close this as the reporter seems lost.
Comment 15 Adam Jackson 2008-06-25 13:32:29 UTC
Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.