Bug 909 - Error building CVS in 'doc/hardcopy/RX
Summary: Error building CVS in 'doc/hardcopy/RX
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Documentation (show other bugs)
Version: git
Hardware: x86 (IA32) All
: high normal
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-20 17:32 UTC by Joseph Felps
Modified: 2004-08-14 00:04 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for 2004-07-27-trunk (3.00 KB, patch)
2004-07-27 20:16 UTC, Roland Mainz
no flags Details | Splinter Review

Description Joseph Felps 2004-07-20 17:32:02 UTC
I've tried building from CVS and I get this error:

make[5]: Entering directory `/home/jfelps1/xcbuild/doc/hardcopy/RX'
+ rm -f RX.ps
+ gzip -d
rm -f RX.pdf
gs -q -sOutputFile=- -sDEVICE=pdfwrite -dSAFER -dNOPAUSE - < RX.ps > RX.pdf
/bin/sh: line 1: gs: command not found
make[5]: *** [RX.pdf] Error 127
make[5]: Leaving directory `/home/jfelps1/xcbuild/doc/hardcopy/RX'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/home/jfelps1/xcbuild/doc/hardcopy'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/jfelps1/xcbuild/doc'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/jfelps1/xcbuild'
make[1]: *** [World] Error 2
make[1]: Leaving directory `/home/jfelps1/xcbuild'
make: *** [World] Error 2
Comment 1 Adam Jackson 2004-07-20 22:52:23 UTC
do you have ghostscript installed?  if not, NOTABUG, though we should probably
fail softer.
Comment 2 Joseph Felps 2004-07-21 08:54:53 UTC
No I don't have Ghostscript, but I didn't have ghostscript when I built from cvs
last week and I never got this error.  Is there a way for me not to build the
hardcopy docs?
Comment 3 Adam Jackson 2004-07-21 11:15:36 UTC
yep.  from xorgsite.def:

/*
 * To disable building some document formats, uncomment some of these.
 *
#define BuildLinuxDocText       NO
#define BuildLinuxDocHtml       NO
#define BuildLinuxDocPS         NO
 */

stick those in your config/cf/host.def
Comment 4 Eric Anholt 2004-07-21 23:40:28 UTC
The build no longer assumes that ghostscript is installed, so those docs won't
be built.  I don't think the loss of these docs by default is worse than having
the build fail for lots of people.

Note: we need a better docs solution.
Comment 5 Roland Mainz 2004-07-27 17:01:03 UTC
(In reply to comment #4)
> The build no longer assumes that ghostscript is installed, so those docs won't
> be built.  I don't think the loss of these docs by default is worse than having
> the build fail for lots of people.

|HasGhostScript| also controls _RUNTIME_ functionality of the tree, not only
docmentation stuff. Short: Something is broken now... ;-((
Comment 6 Roland Mainz 2004-07-27 20:14:30 UTC
Taking myself...
Comment 7 Roland Mainz 2004-07-27 20:16:26 UTC
Created attachment 533 [details] [review]
Patch for 2004-07-27-trunk

The patch adds a new switch |BuildPDFdocs| which can be set to |NO| when PDF
documents should not be generated for some reason.
Comment 8 Roland Mainz 2004-07-27 20:25:27 UTC
Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.141; previous revision: 1.140
/cvs/xorg/xc/config/cf/FreeBSD.cf,v  <--  FreeBSD.cf
new revision: 1.9; previous revision: 1.8
/cvs/xorg/xc/config/cf/Imake.tmpl,v  <--  Imake.tmpl
new revision: 1.6; previous revision: 1.5
/cvs/xorg/xc/config/cf/NetBSD.cf,v  <--  NetBSD.cf
new revision: 1.5; previous revision: 1.4
/cvs/xorg/xc/config/cf/linux.cf,v  <--  linux.cf
new revision: 1.10; previous revision: 1.9
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.
Comment 9 Eric Anholt 2004-07-28 00:15:07 UTC
Please don't add both of my email addresses to bugs.

I disagree with the fix here.  I feel that it is incorrect to be setting
HasGhostScript to YES when that is not true.  OK, it changes runtime behavior,
but will whatever's affected work with ghostscript not being around if it's set
to YES?  If so, then that shouldn't be under the HasGhostscript option, and the
HasGhostscript option should still reflect whether the system in fact has
ghostscript, which should be NO by default.

Needless to say, this will be fixed in FreeBSD, even if my commits get stomped
in CVS.
Comment 10 Roland Mainz 2004-07-28 00:28:51 UTC
(In reply to comment #9)
> Please don't add both of my email addresses to bugs.

Sorry for that...

> I disagree with the fix here.  I feel that it is incorrect to be setting
> HasGhostScript to YES when that is not true.  OK, it changes runtime behavior,
> but will whatever's affected work with ghostscript not being around if it's 
> set
> to YES?  If so, then that shouldn't be under the HasGhostscript option, and 
> the
> HasGhostscript option should still reflect whether the system in fact has
> ghostscript, which should be NO by default.

The settings in Imake usually define what the "common" installation has installed.
When I install SuSE Linux I _always_ have Ghostscript. When I install Redhat
Linux I always have Ghostscript, too. Same applies to Mandrake. And AFAIK
NetBSD, too.
Sure, there is always a way to deinstall it, but then this isn't a "default" OS
installation anymore.

> Needless to say, this will be fixed in FreeBSD, even if my commits get stomped
> in CVS.

We need a consens here. 
Questions:
1. Should I undo the change for FreeBSD again ?
2. Does FreeBSD have Ghostscript installed by default ?
Comment 11 Eric Anholt 2004-07-28 00:58:31 UTC
FreeBSD definitely doesn't have Ghostscript installed by default.  NetBSD
doesn't either, according to folks on #netbsd.  I don't think you could say that
it's default on Debian either, though it's probably more common because of
people installing predefined package sets.
Comment 12 Joseph Felps 2004-07-28 08:08:15 UTC
I just wanted to clarify the problem I was having.  I have these switches set in
my host.def:

#define BuildLinuxDocText       NO
#define BuildLinuxDocHtml       NO
#define BuildLinuxDocPS         NO

And it still seems to be trying to create the gs docs.  I've never had gs
installed.  Just for reference I run Linux from Scratch.
Comment 13 Eric Anholt 2004-08-14 17:04:39 UTC
Fixed HasGhostScript (again) for the BSDs.  Left Linux alone.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.